[webkit-reviews] review denied: [Bug 61649] [EFL] Remove Ecore_X bits from PlatformScreenEfl : [Attachment 95194] Patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 61649: [EFL] Remove Ecore_X bits from PlatformScreenEfl
https://bugs.webkit.org/show_bug.cgi?id=61649

Attachment 95194: Patch
https://bugs.webkit.org/attachment.cgi?id=95194&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95194&action=review

> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:68
> -    int x = 0, y = 0, w = 0, h = 0;
> -
> -#ifdef HAVE_ECORE_X
> -    Ecore_X_Display* display = ecore_x_display_get();
> -    int def = DefaultScreen(display);
> -    Screen* screen = ScreenOfDisplay(display, def);
> -    x = 0;
> -    y = 0;
> -    w = screen->width;
> -    h = screen->height;
> -#endif
> +    int width = 0, height = 0;
>  
> -    return FloatRect(x, y, w, h);
> +    evas_output_size_get(widget->evas(), &width, &height);
> +    return FloatRect(0, 0, width, height);

As we talked through IRC, this is the wrong fix, since you should return the
size of the screen, not the size of your window. I'll submit a patch for this
shortly.