[webkit-reviews] review granted: [Bug 10526] embedded SVG object doesn't scale right : [Attachment 95174] Patch v4

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 10526: embedded SVG object doesn't scale right
https://bugs.webkit.org/show_bug.cgi?id=10526

Attachment 95174: Patch v4
https://bugs.webkit.org/attachment.cgi?id=95174&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95174&action=review

I trust you enough to fix my remarks before landing, no new iteration needed.
You could consider adding some copyrights since you touch most of the time more
than 10 lines of code. r=me

> Source/WebCore/rendering/RenderPart.h:62
> +    mutable bool m_preferredWidthsDependOnContent : 1;

Not used?

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:29
> +#include "FrameTree.h"

Are you sure this include is needed here?

> Source/WebCore/rendering/svg/RenderSVGRoot.cpp:188
> +    return computeIntrinsicWidth(replacedWidth);

You may want to skip the early return style here, as two code paths at the
start of the method end up with the same return statement.

> LayoutTests/svg/wicd/resources/test-svg-child-object-rightsizing.svg:2340
> +<hkern g1="Ccaron" g2="Scedilla" k="0" />

I doubt all this stuff is needed for the test :) Please strip it down as much
as you can before landing.