[webkit-reviews] review denied: [Bug 47980] Add the feature "Add as search engine..." in a search text field context menu for chromium : [Attachment 94064] Proposed Patch V9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 09:18:54 PDT 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied
philippe.beauchamp at gmail.com's request for review:
Bug 47980: Add the feature "Add as search engine..." in a search text field
context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

Attachment 94064: Proposed Patch V9
https://bugs.webkit.org/attachment.cgi?id=94064&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94064&action=review

> Source/WebKit/chromium/src/ContextMenuClientImpl.cpp:277
> +	   WebCore::HTMLFormElement* form =
selectedFrame->selection()->currentForm();

Still don't need WebCore namespace here and elsewhere.


More information about the webkit-reviews mailing list