[webkit-reviews] review granted: [Bug 61449] Update RGBA color serialization to match HTML5 : [Attachment 94811] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 06:44:09 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has granted Andreas Kling
<kling at webkit.org>'s request for review:
Bug 61449: Update RGBA color serialization to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=61449

Attachment 94811: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=94811&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
String::format("%.5f", alpha() / 255.0f)); -> DecimalNumber(alpha() / 255.0)
will create different values regarding float/double and the rounding of
float/dtoa.
But as far as I can see, that is for the better, so r+ :)


More information about the webkit-reviews mailing list