[webkit-reviews] review denied: [Bug 61603] FEConcolveMatrix::getPixelValue() is range checking x against height, instead of y, when determining if a pixel is in bounds : [Attachment 95110] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 27 00:38:05 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has denied Ryan Sleevi
<rsleevi at chromium.org>'s request for review:
Bug 61603: FEConcolveMatrix::getPixelValue() is range checking x against
height, instead of y, when determining if a pixel is in bounds
https://bugs.webkit.org/show_bug.cgi?id=61603

Attachment 95110: Patch
https://bugs.webkit.org/attachment.cgi?id=95110&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Good catch, though we need a test for this. Can you construct a test, that
leads to a crash here? (somehow possible to get y to a negative value via a
test?) CC'ing Zoltan.


More information about the webkit-reviews mailing list