[webkit-reviews] review denied: [Bug 61256] Print HTML with only 1 line, then 2 pages are printed : [Attachment 94934] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kentaro Hara
<haraken at google.com>'s request for review:
Bug 61256: Print HTML with only 1 line, then 2 pages are printed
https://bugs.webkit.org/show_bug.cgi?id=61256

Attachment 94934: Patch
https://bugs.webkit.org/attachment.cgi?id=94934&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't understand where computePageRects() is called from in your example. The
test calls layoutTestController.numberOfPages(), but
PrintContext::numberOfPages() never invokes computePageRects().

It seems that Chromium and/or Chromium DRT may be calling wrong PrintContext
methods.

The way sizes are rounded in PrintContext and above should be agreeing with
each other. There is no guarantee that the error will be under 1.0 otherwise.

This requires a deeper investigation in my opinion.