[webkit-reviews] review requested: [Bug 60563] [Chromium]Click event is not fired for a menulist <select> : [Attachment 95112] Change to use RefPtr.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 26 22:14:32 PDT 2011
Naoki Takano <takano.naoki at gmail.com> has asked for review:
Bug 60563: [Chromium]Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563
Attachment 95112: Change to use RefPtr.
https://bugs.webkit.org/attachment.cgi?id=95112&action=review
------- Additional Comments from Naoki Takano <takano.naoki at gmail.com>
Please review.
1. I cannot write automation test, because PopupMenuTest cannot load test html
file and cannot test event handler.
2. Change to use RefPtr.
3. Clear m_focusedNode after the event forward.
4. Check select popup, because we don't want to fire when autofill.
More information about the webkit-reviews
mailing list