[webkit-reviews] review granted: [Bug 61589] Implement webkit margin collapse CSS properties in CSSStyleApplyProperty : [Attachment 95091] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 19:34:55 PDT 2011


Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 61589: Implement webkit margin collapse CSS properties in
CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=61589

Attachment 95091: Patch
https://bugs.webkit.org/attachment.cgi?id=95091&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95091&action=review

OK.

> Source/WebCore/css/CSSStyleSelector.cpp:-4976
> -	       m_style->setMarginBeforeCollapse(MCOLLAPSE);
> -	       m_style->setMarginAfterCollapse(MCOLLAPSE);

I assume initial* correctly returns these values?


More information about the webkit-reviews mailing list