[webkit-reviews] review granted: [Bug 61559] Transition to full screen video animates in wrong location when scrolled : [Attachment 95050] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 16:54:22 PDT 2011


Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 61559: Transition to full screen video animates in wrong location when
scrolled
https://bugs.webkit.org/show_bug.cgi?id=61559

Attachment 95050: Patch
https://bugs.webkit.org/attachment.cgi?id=95050&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95050&action=review

> Source/WebKit2/WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:56
> +    void animateFullScreen(CATransform3D startTransform, CATransform3D
endTransform, float duration, id listener);

Should these arguments be const CATransform3D& instead of passing by value?


More information about the webkit-reviews mailing list