[webkit-reviews] review granted: [Bug 61554] Make RegExpCache a weak map : [Attachment 95055] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 61554: Make RegExpCache a weak map
https://bugs.webkit.org/show_bug.cgi?id=61554

Attachment 95055: Patch
https://bugs.webkit.org/attachment.cgi?id=95055&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95055&action=review

r=me

> Source/JavaScriptCore/runtime/RegExpCache.h:60
>      RegExpCacheMap m_cacheMap;
> +    int m_nextEntryInStrongCache;
> +    WTF::FixedArray<Strong<RegExp>, maxStrongCacheableEntries>
m_strongCache;

Since you've called the new cache the strong cache, I'd call the other cache
m_weakCache, and a comment for each:
m_strongCache; // Holds a select few regular expressions that have compiled and
executed
m_weakCache; // Holds all regular expressions currently live.