[webkit-reviews] review denied: [Bug 61548] Add 'Skia for rendering, CG for UI' option to Chromium porting layer : [Attachment 95014] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Cary Clark
<caryclark at google.com>'s request for review:
Bug 61548: Add 'Skia for rendering, CG for UI' option to Chromium porting layer
https://bugs.webkit.org/show_bug.cgi?id=61548

Attachment 95014: Patch
https://bugs.webkit.org/attachment.cgi?id=95014&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95014&action=review

> Source/WebKit/chromium/public/WebCommon.h:44
> +	   #define UI_USING_CG 0

this seems like the wrong place for this define.  this is the webkit layer,
which either renders using SKIA or CG.	that's what WEBKIT_USING_SKIA conveys.

it sounds like maybe you want to add a #define in the chromium tree somewhere.

> Source/WebKit/chromium/src/DragClientImpl.cpp:91
> +#if WEBKIT_USING_SKIA && !UI_USING_CG

this seems problematic.  it seems like we should modify the chromium
code which implements WebViewClient::startDragging to understand that
it is getting a SkBitmap instead of a CGImage here.

it would be much better to patch some conversion code into chromium
than to confuse webkit with the notion of supporting two graphics
libraries in different contexts.