[webkit-reviews] review granted: [Bug 57148] Delete table in contentEditable/designMode produces odd contents : [Attachment 95040] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 57148: Delete table in contentEditable/designMode produces odd contents
https://bugs.webkit.org/show_bug.cgi?id=57148

Attachment 95040: Patch
https://bugs.webkit.org/attachment.cgi?id=95040&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95040&action=review

r=me. Looking at new expected results, I say that this is a progression.

> LayoutTests/ChangeLog:13
> +	   Add a test for the case given in the bug: deleting an unstyled table

> +	   should not leave behind a style span.
> +
> +	   Rebaseline tests now that -webkit-border-horizontal-spacing and
-webkit-border-vertical-spacing
> +	   style spans are no longer added on table and table cell deletion,
and no longer applied when
> +	   copying to the clipboard.

It'll be nice to align columns in the future.

> LayoutTests/editing/deleting/delete-last-char-in-table-expected.txt:4
> +PASS

This is great!

> LayoutTests/editing/deleting/delete-last-char-in-table.html:21
> +    var styledSpans = document.getElementsByTagName("span");
> +    result.innerHTML = styledSpans.length == 0 ? "PASS" : "FAIL";

Yup, this works.