[webkit-reviews] review requested: [Bug 61482] [V8] Multiple NPObjects can be created from a single v8::Object : [Attachment 95036] patch #2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 26 14:02:26 PDT 2011
Nate Chapin <japhet at chromium.org> has asked for review:
Bug 61482: [V8] Multiple NPObjects can be created from a single v8::Object
https://bugs.webkit.org/show_bug.cgi?id=61482
Attachment 95036: patch #2
https://bugs.webkit.org/attachment.cgi?id=95036&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
* Cleaned up PluginObject.cpp, made names and variables a little more like the
rest of the file.
* Added call to _NPN_RetainObject when we use a cached V8NPObject, so we don't
use-after-free :)
* Added handling in freeV8NPObject for a GetIdentityHash() = 0, which happens
when the v8 context is gone.
More information about the webkit-reviews
mailing list