[webkit-reviews] review granted: [Bug 61262] [Refactoring] DocumentMarker should be carried around as a pointer, not value. : [Attachment 94385] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 61262: [Refactoring] DocumentMarker should be carried around as a pointer,
not value.
https://bugs.webkit.org/show_bug.cgi?id=61262

Attachment 94385: Patch
https://bugs.webkit.org/attachment.cgi?id=94385&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94385&action=review

Is it possible for us to put OwnPtr in the vector to make the ownership

> Source/WebCore/dom/DocumentMarkerController.cpp:317
> +Vector<DocumentMarker*> DocumentMarkerController::markersFor(Node* node)

Would this work as a Vector<const DocumentMarker*>?

> Source/WebCore/rendering/InlineTextBox.cpp:1092
> +    Vector<DocumentMarker*>::iterator markerIt = markers.begin();

Nit: Could this be a const_iterator?