[webkit-reviews] review granted: [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup : [Attachment 94457] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 41292: [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in
browser, if the call is initiated by user, allow the popup
https://bugs.webkit.org/show_bug.cgi?id=41292

Attachment 94457: Patch
https://bugs.webkit.org/attachment.cgi?id=94457&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94457&action=review

> LayoutTests/ChangeLog:10
> +	   * platform/qt/plugins/plugin-initiate-popup-window-expected.txt:
Copied from
LayoutTests/platform/mac/plugins/plugin-initiate-popup-window-expected.txt.

Can we put the results next to the test instead? In what way are they
platform-specific?

> Source/WebCore/ChangeLog:9
> +	   If the event is from a user gesture, allow popups.

...and the plugin doesn't support the popup-related NPAPI calls, right? You
should mention that here, too.

> Source/WebCore/plugins/qt/PluginViewQt.cpp:390
> +    if (m_plugin->pluginFuncs()->version < NPVERS_HAS_POPUPS_ENABLED_STATE
> +	   && (event.type == ButtonRelease || event.type == 3 /*KeyRelease*/))
{

Is there really no constant for KeyRelease?