[webkit-reviews] review granted: [Bug 61474] WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle : [Attachment 95021] [PATCH] Fix v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 12:31:12 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 61474: WebKit2: Status bar, toolbar, and menu bar checks should be in the
injected bundle
https://bugs.webkit.org/show_bug.cgi?id=61474

Attachment 95021: [PATCH] Fix v4
https://bugs.webkit.org/attachment.cgi?id=95021&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=95021&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:201
> +    WKBundlePageUIElementVisibility toolbarsVisible =
m_page->injectedBundleUIClient().toolbarsAreVisible(m_page);

I'd call the variable toolbarsVisibility, instead of toolbarsVisible. (Ditto
for the other local variables you added in this patch.)


More information about the webkit-reviews mailing list