[webkit-reviews] review denied: [Bug 61536] [Chromium] Add missing compile guards for WebWorkers in WebKit : [Attachment 95018] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 26 12:22:51 PDT 2011
Dmitry Titov <dimich at chromium.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 61536: [Chromium] Add missing compile guards for WebWorkers in WebKit
https://bugs.webkit.org/show_bug.cgi?id=61536
Attachment 95018: Patch
https://bugs.webkit.org/attachment.cgi?id=95018&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95018&action=review
One small thing:
> Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:99
> delete this;
I think this 'delete' is not needed now since there is OwnPtr for 'this'...
While at this, lets add a comment to the OwnPtr about this object self-deleting
on exit, to make it more explicit.
More information about the webkit-reviews
mailing list