[webkit-reviews] review granted: [Bug 61015] Support crossorigin property for images : [Attachment 95011] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 61015: Support crossorigin property for images
https://bugs.webkit.org/show_bug.cgi?id=61015

Attachment 95011: Patch
https://bugs.webkit.org/attachment.cgi?id=95011&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95011&action=review

OK.  I didn't review the tests particularly closely.  If you need me to, I'm
happy to take another look.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:92
> +static bool isOriginClean(CachedImage* cachedImage, SecurityOrigin*
securityOrigin)

OMG, so much nicer, thank you.

> Source/WebCore/loader/ImageLoader.cpp:168
> +	       updateRequestForAccessControl(request,
document->securityOrigin(), allowCredentials);

I really dislike these being free functions.  We should consider namspacing
them in a class at some point.