[webkit-reviews] review granted: [Bug 61492] Safari's AXFocusedUIElement attribute returns WebArea object with AXSelectedTextMarkerRange of nil : [Attachment 94899] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 61492: Safari's AXFocusedUIElement attribute returns WebArea object with
AXSelectedTextMarkerRange of nil
https://bugs.webkit.org/show_bug.cgi?id=61492

Attachment 94899: patch
https://bugs.webkit.org/attachment.cgi?id=94899&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94899&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1969
> +    bool windowIsVisible = true;
> +#if PLATFORM(MAC)
> +    windowIsVisible = m_windowIsVisible;
> +#endif
>      
> +    return windowIsVisible && m_page->focusController()->isFocused() &&
m_page->focusController()->isActive();

This could be done much cleaner:

    #if PLATFORM(MAC)
	if (!m_windowIsVisible)
	    return false;
    #endif
	return m_page->focusController()->isFocused() &&
m_page->focusController()->isActive();

I’m also a bit surprised that we need to check isActive.