[webkit-reviews] review denied: [Bug 61474] WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle : [Attachment 94900] [PATCH] Fix v3

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 61474: WebKit2: Status bar, toolbar, and menu bar checks should be in the
injected bundle
https://bugs.webkit.org/show_bug.cgi?id=61474

Attachment 94900: [PATCH] Fix v3
https://bugs.webkit.org/attachment.cgi?id=94900&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94900&action=review

Did you make sure you don't need to modify MiniBrowser or You need to modify
MiniBrowser or qwkpage.cpp?

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:179
> +enum {
> +    WKBundlePageUIBooleanPassThrough,
> +    WKBundlePageUIBooleanTrue,
> +    WKBundlePageUIBooleanFalse
> +};
> +typedef uint32_t WKBundlePageUIBoolean;

Calling this a "boolean" feels a little weird. Booleans usually only have two
states! Maybe something a little less generic would work better, like:

enum {
    WKBundlePageUIElementVisibilityUnknown,
    WKBundlePageUIElementVisible,
    WKBundlePageUIElementHidden,
};
typedef uint32_t WKBundlePageUIElementVisibility;