[webkit-reviews] review denied: [Bug 61536] [Chromium] Add missing compile guards for WebWorkers in WebKit : [Attachment 94992] Patch

[bugzilla-daemon at webkit.org]

Dmitry Titov <dimich at chromium.org> has denied Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 61536: [Chromium] Add missing compile guards for WebWorkers in WebKit
https://bugs.webkit.org/show_bug.cgi?id=61536

Attachment 94992: Patch
https://bugs.webkit.org/attachment.cgi?id=94992&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94992&action=review

Great! Couple of comments, lets do another iteration:

> Source/WebKit/chromium/src/DatabaseObserver.cpp:71
> +	   return false;

Lets add ASSERT_NOT_REACHED() here, to document that we don't expect any other
case but Document in this case.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:101
> +	   allowed = false;

Same as above, ASSERT_NOT_REACHED() could be useful here.

> Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:96
> +    m_callbacks->didOpenFileSystem(name,
AsyncFileSystemChromium::create(m_type, path));

This duplicates a line of code... By placing #if/#endif around if/else, it's
possible to avoid that.