[webkit-reviews] review granted: [Bug 61508] DFG JIT - Add support for get by id self caching. : [Attachment 94936] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 61508: DFG JIT - Add support for get by id self caching.
https://bugs.webkit.org/show_bug.cgi?id=61508

Attachment 94936: The patch
https://bugs.webkit.org/attachment.cgi?id=94936&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94936&action=review

Please fix style bot issues and change C-style casts to C++-style casts.

r=me

> Source/JavaScriptCore/dfg/DFGRepatch.cpp:46
> +    // Only optimize once!

I still think it's crazy that all of this stuff is called "repatch" even though
it can only happen once. This comment fills me with sad irony.