[webkit-reviews] review denied: [Bug 55233] XSL transformations do not handle errors : [Attachment 94877] Patch (No tests)

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 55233: XSL transformations do not handle errors
https://bugs.webkit.org/show_bug.cgi?id=55233

Attachment 94877: Patch (No tests)
https://bugs.webkit.org/attachment.cgi?id=94877&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94877&action=review

This looks pretty cool, but we'll need some tests!  (I didn't review deeply.)

> Source/WebCore/xml/XMLErrors.cpp:68
> +	       m_errorMessages += "warning in " + sourceURL + " on line" +
String::number(position.m_line.oneBasedInt()) + " at column " +
String::number(position.m_column.oneBasedInt()) + ": " + m;

Is there an XSS risk here?  Should we sandbox error pages to be extra-sure?