[webkit-reviews] review denied: [Bug 43452] SVG animation beginElement() does not restart a stopped animation. : [Attachment 94602] Bugfix for SVG animation restarting.

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Felician Marton
<marton.felician.zoltan at stud.u-szeged.hu>'s request for review:
Bug 43452: SVG animation beginElement() does not restart a stopped animation.
https://bugs.webkit.org/show_bug.cgi?id=43452

Attachment 94602: Bugfix for SVG animation restarting.
https://bugs.webkit.org/attachment.cgi?id=94602&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94602&action=review

Great that you are working on this! I am r- because of my suggestions and
questions.

> LayoutTests/ChangeLog:11
> +	   Added test for animation beginElement. It should restart the
animation even if the animation is stopped by endElement() previously.

This line should move up to be below the 2 bugfix lines

> LayoutTests/svg/animations/script-tests/animate-endElement-beginElement.js:56

> +button.setAttribute("onclick", "executeTest()");

Can you explain why button is needed? If not, can you remove it and put the
onclick on the rect?

> Source/WebCore/ChangeLog:11
> +	   (WebCore::SVGSMILElement::findInstanceTime): changed the return
value when we search in the endTimes vector and there is no proper match.

s/changed/Changed