[webkit-reviews] review denied: [Bug 61515] [Chromium] fix a layout test crash except for mac (LayoutTest/fast/forms/select-script-onchange.html) : [Attachment 94956] Fix style bugs

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 61515: [Chromium] fix a layout test crash except for mac
(LayoutTest/fast/forms/select-script-onchange.html)
https://bugs.webkit.org/show_bug.cgi?id=61515

Attachment 94956: Fix style bugs
https://bugs.webkit.org/attachment.cgi?id=94956&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
(In reply to comment #0)
> It cause calling WebViewHost::createPopupMenu() on SPACE_OR_RETURN_POP_MENU
platform,
> and it's not implemented by DumpRenderTree for chromium
> (Tools/DumpRenderTree/chromium/WebViewHost.cpp:241).

Right.	So we should implement popup menu in DRT/Chromium.

> Originally "\r" must be intended to call htmlForm->submitImplicitly() on
ARROW_KEYS_POP_MENU platform.

No.  Select elements in the test don't have their parent forms.  So
submitImplicitly() is not called.