[webkit-reviews] review granted: [Bug 59193] Web Inspector: Use different SourceFrame instances for ResourcesPanel and NetworkPanel : [Attachment 94781] Patch with fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 07:09:40 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 59193: Web Inspector: Use different SourceFrame instances for
ResourcesPanel and NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=59193

Attachment 94781: Patch with fixes
https://bugs.webkit.org/attachment.cgi?id=94781&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94781&action=review

> Source/WebCore/inspector/front-end/ResourceView.js:152
> +	       this.resource.setContent(this._textModel.text, majorChange,
function() {});

Please remove last parameter since it's optional. In similar calls above it's
just omitted.


More information about the webkit-reviews mailing list