[webkit-reviews] review requested: [Bug 61287] [UNIX] Don't use SOCK_DGRAM in socketpair() : [Attachment 94943] New patch using SOCK_SEQPACKET when available
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 26 01:59:27 PDT 2011
Carlos Garcia Campos <cgarcia at igalia.com> has asked for review:
Bug 61287: [UNIX] Don't use SOCK_DGRAM in socketpair()
https://bugs.webkit.org/show_bug.cgi?id=61287
Attachment 94943: New patch using SOCK_SEQPACKET when available
https://bugs.webkit.org/attachment.cgi?id=94943&action=review
------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Actually, I think falling back to STREAM sockets is much easier than using a
dummy socket, because we can use the same code for both STREAM and SEQPACKET
sockets. For SEQPACKET m_readBufferSize == messageLength &&
m_fileDescriptorsSize == messageInfo.attachmentCount() so it will never
memmove.
More information about the webkit-reviews
mailing list