[webkit-reviews] review denied: [Bug 58727] [Qt] QWebView can not show eBay pages correctly : [Attachment 92487] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 58727: [Qt] QWebView can not show eBay pages correctly
https://bugs.webkit.org/show_bug.cgi?id=58727

Attachment 92487: patch
https://bugs.webkit.org/attachment.cgi?id=92487&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92487&action=review

r- because neither the ChangeLog nor the hunk in QNetworkReplyHandler explain
why this is done, i.e. why QNAM sets ProtocolFailure but we choose to ignore
it.

> Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp:430
> +    if (httpStatusCode == 200 && reply->error() ==
QNetworkReply::ProtocolFailure)
> +	   return true;
> +

Please find out why QNAM is setting ProtocolFailure as error here. If the
situation is justified, we should explain with a comment why we ignore the
error.