[webkit-reviews] review denied: [Bug 32865] [Qt] QWebElement::attribute always returns empty result for input's values : [Attachment 94578] Style fixed

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied wolfy <wolfram at ritsuka.org>'s
request for review:
Bug 32865: [Qt] QWebElement::attribute always returns empty result for input's
values
https://bugs.webkit.org/show_bug.cgi?id=32865

Attachment 94578: Style fixed
https://bugs.webkit.org/attachment.cgi?id=94578&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm going to say r- because of the previous comment in the sense that this
makes setAttribute() inconsistent to setAttributeNS() (and the same for the
getters).

Unless someone comes up with a nicer proposal I'd suggest we solve this when we
introduce the QtScript dependency. Then we can have for example

    QScriptValue QWebElement::scriptObject()

and you can do

    element.setAttribute("value", "this is the initial value");

    QScriptValue jsobject = element.scriptObject();
    jsobject.setProperty("value", "current text");