[webkit-reviews] review requested: [Bug 61482] [V8] Multiple NPObjects can be created from a single v8::Object : [Attachment 94882] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 25 17:02:47 PDT 2011


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 61482: [V8] Multiple NPObjects can be created from a single v8::Object
https://bugs.webkit.org/show_bug.cgi?id=61482

Attachment 94882: patch
https://bugs.webkit.org/attachment.cgi?id=94882&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This patch makes use of v8::Object::GetIdentityHash(), an item in the v8 api
previously unused in WebCore.

Anton tells me it isn't free to use, but given that creating V8NPObjects is
relatively uncommon and that this is the only sane way to use a v8::Object as a
key in a map, I'm inclined to use it.


More information about the webkit-reviews mailing list