[webkit-reviews] review granted: [Bug 61476] Generate regexp code lazily : [Attachment 94872] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 61476: Generate regexp code lazily
https://bugs.webkit.org/show_bug.cgi?id=61476

Attachment 94872: Patch
https://bugs.webkit.org/attachment.cgi?id=94872&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94872&action=review

r=me

> Source/JavaScriptCore/runtime/RegExp.cpp:113
> +void RegExp::recompile(JSGlobalData& globalData)
> +{
> +    m_representation = adoptPtr(new RegExpRepresentation);
> +    m_state = compile(&globalData);
> +}
> +
>  RegExp::RegExpState RegExp::compile(JSGlobalData* globalData)

I think these two functions should merge into a function called "compile", and
"recompileIfNecessary" should be "compileIfNecessary", since it gets called for
initial compilation, and not just recompilation.