[webkit-reviews] review granted: [Bug 61407] QuickLooks quirk is expensive to calculate : [Attachment 94748] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 25 14:22:46 PDT 2011


Brady Eidson <beidson at apple.com> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 61407: QuickLooks quirk is expensive to calculate
https://bugs.webkit.org/show_bug.cgi?id=61407

Attachment 94748: patch
https://bugs.webkit.org/attachment.cgi?id=94748&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94748&action=review

r+ with the following changes:

> Source/WebCore/loader/FrameLoader.cpp:2416
> +    if (request.cachePolicy() == ReloadIgnoringCacheData &&
ResourceRequest::useQuickLookResourceCachingQuirks() &&
!equalIgnoringCase(request.httpMethod(), "post"))

You can put the !equalIgnoringCase(request.httpMethod(), "post") before the
useQuickLookResourceCachingQuirks() for an even more "less likely to calculate
the quicklooks quirks" setup.

> Source/WebCore/platform/network/mac/ResourceRequestMac.mm:182
> +    const char* bundleID = [[[NSBundle mainBundle] bundleIdentifier]
UTF8String];
> +    if (bundleID && !strcasecmp(bundleID, "com.apple.Safari"))
> +	   return false;

You should use applicationIsSafari() in RuntimeApplicationChecks


More information about the webkit-reviews mailing list