[webkit-reviews] review granted: [Bug 61403] Video fails to play on Vimeo : [Attachment 94853] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 25 14:08:03 PDT 2011


Darin Adler <darin at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61403: Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403

Attachment 94853: Patch
https://bugs.webkit.org/attachment.cgi?id=94853&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94853&action=review

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObj
C.mm:786
> +    return resolvedOrigin->isSameSchemeHostPort(requestedOrigin.get());

This check is probably too strict.

The correct check would probably be to check if the original security origin
SecurityOrigin::canRequest the resolved asset URL. The original assertURL
doesn’t matter at all.

We can live with this for now.


More information about the webkit-reviews mailing list