[webkit-reviews] review granted: [Bug 61417] [Chromium] WebDatabase::closeDatabaseImmediately fails sometimes. : [Attachment 94841] SimplerStringKey

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 61417: [Chromium] WebDatabase::closeDatabaseImmediately fails sometimes.
https://bugs.webkit.org/show_bug.cgi?id=61417

Attachment 94841: SimplerStringKey
https://bugs.webkit.org/attachment.cgi?id=94841&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94841&action=review

> Source/WebCore/storage/DatabaseTracker.h:181
> +    typedef HashMap<String, DatabaseNameMap*> DatabaseOriginMap;

I guess duplicating the above typedefs and the definition of
m_openDatabaseMapGuard
is helpful since the type of DatabaseOriginMap is different now?  This way you
can
keep all of these together?  Another approach would be to #ifdef just the
definition
of DatabaseOriginMap.  Then, the rest of the code duplication would not need to
exist.