[webkit-reviews] review requested: [Bug 49468] [Qt] Assertion failure in DocumentLoader::commitData when loading a media document : [Attachment 94838] Put changes and tests together in one patch.

[bugzilla-daemon at webkit.org]

Joe Wild <joseph.wild at nokia.com> has asked  for review:
Bug 49468: [Qt] Assertion failure in DocumentLoader::commitData when loading a
media document
https://bugs.webkit.org/show_bug.cgi?id=49468

Attachment 94838: Put changes and tests together in one patch.
https://bugs.webkit.org/attachment.cgi?id=94838&action=review

------- Additional Comments from Joe Wild <joseph.wild at nokia.com>
I put the change and test into one patch.

I put the test under platform/qt since it uses
layoutTestController.handleErrorPages() which is only available with
Qt and my change was in Qt files.

I have to admit that I hate this test for all the reasons mentioned
in comment #5, but don't have any good ideas of how to enable the plugin
support better for run-webkit-tests.  Suggestions welcome.

At least, I don't think this test should cause noise without the proper
plugin setup. It will just pass.  Problem is that it will likely not
fail when it is supposed to.