[webkit-reviews] review requested: [Bug 61270] IndexedDB: Support LevelDB transactions. : [Attachment 94797] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 25 09:51:15 PDT 2011


Hans Wennborg <hans at chromium.org> has asked  for review:
Bug 61270: IndexedDB: Support LevelDB transactions.
https://bugs.webkit.org/show_bug.cgi?id=61270

Attachment 94797: patch
https://bugs.webkit.org/attachment.cgi?id=94797&action=review

------- Additional Comments from Hans Wennborg <hans at chromium.org>
Some changes after walking through the code with Steve:

- Simplify TransactionIterator::next() and prev() by introducing a nonCurrent
variable
- Use a variable to determine whether to keep looping in
TransactionIterator::handleConflictsAndDeletes()
- Add comment about LevelDBWriteBatch::remove()


More information about the webkit-reviews mailing list