[webkit-reviews] review granted: [Bug 58210] webkit should implement the dropzone attribute : [Attachment 93541] Patch.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 58210: webkit should implement the dropzone attribute
https://bugs.webkit.org/show_bug.cgi?id=58210

Attachment 93541: Patch.
https://bugs.webkit.org/attachment.cgi?id=93541&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=93541&action=review

Please try to figure out why cr-linux is failing or add it to
LayoutTests/platform/chromium/test_expectations.txt.  Something like:
BUGWKXXX : fast/events/dropzone-002.html = TEXT

> Source/WebCore/dom/Clipboard.cpp:207
> +    default:
> +	   return String("copy");

Nit: Maybe add an ASSERT_NOT_REACHED()?

> Source/WebCore/page/EventHandler.cpp:1784
> +    for (; element; element = element->parentElement()) {

I think this is fine for now, but we may want to profile how much time we spend
parsing the dropzone attribute since we do this on every mousemove during a
drag.  If it's a lot of time, we may want to cache the parsed result.