[webkit-reviews] review denied: [Bug 46506] [mac] Pass all of Philip's Canvas Test Suite : [Attachment 94780] Fixes the canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Philip Rogers <pdr at google.com>'s
request for review:
Bug 46506: [mac] Pass all of Philip's Canvas Test Suite
https://bugs.webkit.org/show_bug.cgi?id=46506

Attachment 94780: Fixes the
canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html test
https://bugs.webkit.org/attachment.cgi?id=94780&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94780&action=review

Also, this patch should be on its own bug, and that bug should block 46506.

> Source/WebCore/ChangeLog:7
> +	   No new tests. (OOPS!)

You should remove the now-passing test(s) from the relevant skip lists.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1868
> +    if (useMaxWidth && maxWidth <= 0)
> +	   return;

We should also return if !isfinite(maxWidth).
(HTML5: "Except where otherwise specified, for the 2D context interface, any
method call with a numeric argument whose value is infinite or a NaN value must
be ignored.")

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1909
> +    if (fontWidth <= 0)
> +	   return;

This check should be right after assigning to 'fontWidth'.