[webkit-reviews] review requested: [Bug 59693] [Feature Request] Need SpellCheck API : [Attachment 94769] Patch v2 (only for Chromium)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 25 04:38:32 PDT 2011


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 59693: [Feature Request] Need SpellCheck API
https://bugs.webkit.org/show_bug.cgi?id=59693

Attachment 94769: Patch v2 (only for Chromium)
https://bugs.webkit.org/attachment.cgi?id=94769&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

(In reply to comment #6)
> Source/WebCore/html/HTMLTextAreaElement.cpp:55:  Alphabetical sorting
problem.  [build/include_order] [4]
> Source/WebCore/html/HTMLInputElement.cpp:64:	Alphabetical sorting problem. 
[build/include_order] [4]
> Source/WebCore/html/HTMLDivElement.cpp:33:  Alphabetical sorting problem. 
[build/include_order] [4]
> Source/WebCore/dom/DocumentMarkerController.h:85:  The parameter name "node"
adds no information, so it should be removed.  [readability/parameter_name] [5]

> Total errors found: 4 in 30 files

Oops, I forgot running check-webkit-style. I have updated my change.

Regards,

Hironori Bono


More information about the webkit-reviews mailing list