[webkit-reviews] review denied: [Bug 58531] Handling invalid colors in SVG : [Attachment 94760] updated patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Oliver Varga
<Varga.Oliver at stud.u-szeged.hu>'s request for review:
Bug 58531: Handling invalid colors in SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Attachment 94760: updated patch
https://bugs.webkit.org/attachment.cgi?id=94760&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94760&action=review

Almost there, please fix the tabs and the duplicated ChangeLog entry, then I'll
r+/cq+.

> Source/WebCore/ChangeLog:27
> +2011-05-25  Oliver Varga  <Varga.Oliver at stud.u-szeged.hu>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Handling invalid colors in SVG. Fixed color inheritance (fill,
stroke, uri).
> +	   https://bugs.webkit.org/show_bug.cgi?id=58531
> +
> +	   Tests: svg/custom/invalid-stroke-hex.svg
> +		  svg/custom/invalid-uri-stroke.svg
> +		  svg/custom/invalid-uri.svg
> +
> +	   * rendering/svg/RenderSVGResource.cpp: Fix fallback.
> +	   (WebCore::requestPaintingResource):

Double entry.