[webkit-reviews] review granted: [Bug 61420] WebKit2: Web Inspector: Web Inspector opens a blank window when a breakpoint is hit when docked : [Attachment 94744] Proposed Change

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 61420: WebKit2: Web Inspector: Web Inspector opens a blank window when a
breakpoint is hit when docked
https://bugs.webkit.org/show_bug.cgi?id=61420

Attachment 94744: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=94744&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94744&action=review

>>> Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:230
>>> +	 HWND parentWindow = m_isAttached ? ::GetParent(m_page->nativeWindow())
: m_inspectorWindow;
>> 
>> Actually, I'm not sure if this is right in the non-attached case. We might
want this to be - ::GetAncestor(m_page->nativeWindow(), GA_ROOT). We bring the
root window to the front, which isn't necessarily the parent of the web view.
> 
> Actually, I'm not sure if this is right in the non-attached case. We might
want this to be - ::GetAncestor(m_page->nativeWindow(), GA_ROOT). We bring the
root window to the front, which isn't necessarily the parent of the web view.

This should be:

HWND parentWindow = m_isAttached ? ::GetAncestor(m_page->nativeWindow(),
GA_ROOT) : m_inspectorWindow;

And it will need the same FIXME as the Mac code.