[webkit-reviews] review granted: [Bug 34635] [Qt] When QWebView has a different style set on it then the scrollbars are not rendered correctly : [Attachment 94641] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 21:58:10 PDT 2011
Antonio Gomes <tonikitoo at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 34635: [Qt] When QWebView has a different style set on it then the
scrollbars are not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=34635
Attachment 94641: Patch
https://bugs.webkit.org/attachment.cgi?id=94641&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94641&action=review
> Source/WebCore/ChangeLog:9
> + two paths one for Mac and one for any other styles. The problem is
that on Mac you can still run the
needs a comma after "two paths"
> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:161
> + if (qobject_cast<QMacStyle *>(style()))
unneeded space.
> Source/WebCore/platform/qt/ScrollbarThemeQt.cpp:170
> + // The QStyle expects the background to be already filled
missing dot in the end.
More information about the webkit-reviews
mailing list