[webkit-reviews] review denied: [Bug 61403] Video fails to play on Vimeo : [Attachment 94720] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 21:23:39 PDT 2011
Maciej Stachowiak <mjs at apple.com> has denied Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 61403: Video fails to play on Vimeo
https://bugs.webkit.org/show_bug.cgi?id=61403
Attachment 94720: Patch
https://bugs.webkit.org/attachment.cgi?id=94720&action=review
------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94720&action=review
r- because this appears to break the build. I am not entirely sure why, and
otherwise it seems ok though see other comment.
>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObj
C.mm:259
> - [NSNumber
numberWithInt:AVAssetReferenceRestrictionForbidCrossSiteReference],
AVURLAssetReferenceRestrictionsKey,
> + [NSNumber
numberWithInt:AVAssetReferenceRestrictionForbidRemoteReferenceToLocal |
AVAssetReferenceRestrictionForbidLocalReferenceToRemote],
AVURLAssetReferenceRestrictionsKey,
Is there any way we can allow cross-origin redirects (which seem safe enough)
while still preventing cross-origin auxiliary resource references (e.g.
reference movies)? I think that should be the goal, but if that's not
achievable, this approach seems ok.
More information about the webkit-reviews
mailing list