[webkit-reviews] review granted: [Bug 61352] Refactor RenderView::{enable, disable}LayoutState call sites to use RIIA : [Attachment 94588] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 17:28:31 PDT 2011
Kent Tamura <tkent at chromium.org> has granted Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 61352: Refactor RenderView::{enable,disable}LayoutState call sites to use
RIIA
https://bugs.webkit.org/show_bug.cgi?id=61352
Attachment 94588: Patch
https://bugs.webkit.org/attachment.cgi?id=94588&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94588&action=review
looks good.
> Source/WebCore/page/FrameView.cpp:987
> + if (subtree) {
> + RenderView* view = root->view();
> + view->popLayoutState(root);
> + }
nit: The variable 'view' is not needed.
if (subtree)
root->view()->popLayoutState(root);
More information about the webkit-reviews
mailing list