[webkit-reviews] review granted: [Bug 61222] Improve handling in WebCore of low memory situations : [Attachment 94708] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 16:31:21 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 61222: Improve handling in WebCore of low memory situations
https://bugs.webkit.org/show_bug.cgi?id=61222

Attachment 94708: Updated patch
https://bugs.webkit.org/attachment.cgi?id=94708&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=94708&action=review

r=me

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:89
> +    pageCache()->setCapacity(pageCache()->pageCount()>>1);

The compiler will do this for you, so there's no need to be clever.

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:95
> +    [nsurlCache setMemoryCapacity:[nsurlCache currentMemoryUsage]>>1];

The compiler will do this for you, so there's no need to be clever.


More information about the webkit-reviews mailing list