[webkit-reviews] review granted: [Bug 61345] lazily init ResourceResponse suggested filename. : [Attachment 94700] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 15:21:41 PDT 2011


Geoffrey Garen <ggaren at apple.com> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 61345: lazily init ResourceResponse suggested filename.
https://bugs.webkit.org/show_bug.cgi?id=61345

Attachment 94700: patch
https://bugs.webkit.org/attachment.cgi?id=94700&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I agree with ap -- better names would help indicate that each successive level
of the enum is inclusive of previous levels. I'd suggest:

	CommonFields,
	CommonAndUncommonFields,
	AllFields

r=me with that change


More information about the webkit-reviews mailing list