[webkit-reviews] review granted: [Bug 61318] Make CachedResource take a ResourceRequest instead of just a url string. : [Attachment 94629] patch #2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 12:53:04 PDT 2011


Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 61318: Make CachedResource take a ResourceRequest instead of just a url
string.
https://bugs.webkit.org/show_bug.cgi?id=61318

Attachment 94629: patch #2
https://bugs.webkit.org/attachment.cgi?id=94629&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I agree that this makes the call sites slightly more verbose, but that seems
better than having some of functions use URLs and others use ResourceRequests. 
We can either to the API conversion in this patch or the next patch, but doing
it in this patch is probably best since this patch shouldn't have any behavior
changes and the next patches all introduce new behavior.


More information about the webkit-reviews mailing list