[webkit-reviews] review granted: [Bug 61333] Convert LayoutTests/editing/deleting/delete-block-table.html to dump-as-markup : [Attachment 94658] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 24 12:17:26 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 61333: Convert LayoutTests/editing/deleting/delete-block-table.html to
dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61333

Attachment 94658: Patch
https://bugs.webkit.org/attachment.cgi?id=94658&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94658&action=review

The following comments for future references.

> LayoutTests/editing/deleting/delete-block-table.html:27
> +<script src=../editing.js></script>

I would prefer to wrap URL by (double) quotations but that's fine.

> LayoutTests/editing/deleting/delete-block-table.html:37
> +    for (i = 0; i < 3; i++) {
> +	   deleteCommand();
> +    }

No curly brackets around a single statement.


More information about the webkit-reviews mailing list