[webkit-reviews] review denied: [Bug 61333] Convert LayoutTests/editing/deleting/delete-block-table.html to dump-as-markup : [Attachment 94651] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 24 11:51:30 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied Annie Sullivan
<sullivan at chromium.org>'s request for review:
Bug 61333: Convert LayoutTests/editing/deleting/delete-block-table.html to
dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61333
Attachment 94651: Patch
https://bugs.webkit.org/attachment.cgi?id=94651&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94651&action=review
Even though it's a minor change, I'd say r- since you're not a committer yet.
> LayoutTests/ChangeLog:8
> + Converts delete-block-table.html to dump-as-markup by changing to
use runDumpAsTextEditingTest.
runDumpAsTextEditingTest don't use dump-as-markup.js so you should either say
text test or dumpAsTest test.
More information about the webkit-reviews
mailing list