[webkit-reviews] review granted: [Bug 61098] Web Inspector: Provide inspector extension API to access timeline data : [Attachment 94216] Proposed Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 61098: Web Inspector: Provide inspector extension API to access timeline
data
https://bugs.webkit.org/show_bug.cgi?id=61098

Attachment 94216: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=94216&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=94216&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:300
> +	      
this._addRecordToTimeline(JSON.parse(JSON.stringify(event.data)));

Extensions should not regress devtools performance for no good reason. Andrei
has a nasty workaround for it if you want this patch to land sooner. I can r+
it provided that Andrei patches record's proto and lands this change by hand.